Dear @baurmatt, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

@baurmatt I appreciate the work you have done, but please follow the style guide:

• https://puppet.com/docs/puppet/latest/puppet_strings_style.html

For example, the new line after @param xyz is missing and you should keep an eye at the length of a line. It should be readable with any common editor.

Hey @dhoppe, thanks for taking a look! :) I've indeed found a couple of things which should be fixed (assert_private()/@api not used, different ways of getting the variables into the subclasses, inconsistent documentation strings, ...). I've explicitly decided against fixing it because the PR is already really huge.

I think this is a good first step, thanks for the work!